Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring TLS 1.3 support #86

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

SebaLukas
Copy link
Collaborator

@SebaLukas SebaLukas commented Feb 20, 2025

Describe your changes

Refactoring connection_ssl:

  • Updating TLS1.3 support
  • Setting on runtime the verify mode based on tls version
  • Generating the vehicle cert leaf hash for pause/resume
  • Refactoring the tls_keylog callback
  • Adding a standalone connection_openssl test / standalone tls server to test the server, generating own certs for this tls server and openssl client

Issue ticket number and link

A prober tls 1.3 support is missing. This PR changes that. For Pause/Resume a prober TLS 1.3 support is necessary.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

…ode based on tls version, generate the vehicle cert leaf hash for pause/resume, added a standalone connection_openssl test / standalone tls server to test the server, generate own certs for this tls server and openssl client

Signed-off-by: Sebastian Lukas <[email protected]>
Copy link
Contributor

@AssemblyJohn AssemblyJohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one note that I'd have on this PR. I know it will be quite complicated, but is there any way that we can have this test somehow introduced in the unit tests (and as a result introduced in the CI)?

From my experience with other conn/servers even if some integration tests do not test everything it would be a huge help when further modifying this class.

The integration test could do something simple, as to open 2 child processes, or to run a script (std::system) or something along those lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants