Review comments.

Signed-off-by: Maaike Zijderveld, iolar <[email protected]>
EVerest · Nov 25, 2024 · d9b3372 · d9b3372
1 parent 7840131
commit d9b3372
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -93,7 +93,7 @@ The following table shows the known CSMS with which this library was tested.
 | E. Transactions                      | ✅ yes  |
 | F. RemoteControl                     | ✅ yes  |
 | G. Availability                      | ✅ yes  |
-| H. Reservation                       | WIP                       |
+| H. Reservation                       | ✅ yes                      |
 | I. TariffAndCost                     | ✅ yes  |
 | J. MeterValues                       | ✅ yes  |
 | K. SmartCharging                     | WIP                       |

diff --git a/lib/ocpp/v201/evse.cpp b/lib/ocpp/v201/evse.cpp
@@ -221,7 +221,13 @@ std::optional<ConnectorEnum> Evse::get_evse_connector_type(const uint32_t connec
         return std::nullopt;
     }
 
-    return conversions::string_to_connector_enum(connector_type.value());
+    try {
+        return conversions::string_to_connector_enum(connector_type.value());
+    }
+    catch (const StringToEnumException& e) {
+        EVLOG_warning << "Could not convert to ConnectorEnum: " << connector_type.value();
+        return std::nullopt;
+    }
 }
 
 void Evse::open_transaction(const std::string& transaction_id, const int32_t connector_id, const DateTime& timestamp,