J01- Add evseId=0 meter values #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#187 must be merged first to rebase this branch |
marcemmers
requested changes
Sep 28, 2023
lib/ocpp/v201/charge_point.cpp
Outdated
| @@ -284,7 +295,18 @@ void ChargePoint::on_session_finished(const int32_t evse_id, const int32_t conne | |||
| } | |||
|
|
|||
| void ChargePoint::on_meter_value(const int32_t evse_id, const MeterValue& meter_value) { | |||
| this->evses.at(evse_id)->on_meter_value(meter_value); | |||
| std::lock_guard<std::mutex> lk(this->meter_value_mutex); | |||
There was a problem hiding this comment.
You only need to lock this in case your writing to this->meter_value, not the evse because it has its own lock ;)
lib/ocpp/v201/charge_point.cpp
Outdated
| EVLOG_debug << "Next meter value will be sent at: " << next_timestamp.value().to_rfc3339(); | ||
| this->aligned_meter_values_timer.at( | ||
| [this]() { | ||
| [this, &transaction_active]() { |
There was a problem hiding this comment.
I don't think this is safe to do because at the time the lambda function will be called the boolean will be out of scope.
SNSubramanya
force-pushed
the
J01-MeterValues
branch
from
4794fc3 to
ebbee47
Compare
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Add a measurerand filter for evseID 0 Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
SNSubramanya
force-pushed
the
J01-MeterValues
branch
from
ebbee47 to
52390f4
Compare
marcemmers
requested changes
Oct 13, 2023
config/v201/config.json
Outdated
| "attributes": { | ||
| "Actual": 42 | ||
| } | ||
| { |
There was a problem hiding this comment.
So it seems like you made some more changes here during the rebase than intended ;)
There was a problem hiding this comment.
Ah... sorry i think i made a mistake during the rebasing...
Co-authored-by: marcemmers <[email protected]> Signed-off-by: SNSubramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
marcemmers
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.