OCPP201: SignCertificate and CertificateSigned #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Pietfried
commented
Oct 11, 2023
•
Pietfried
commented
- added handling for security: A02 (SignCertificate, CertificateSigned)
Pietfried
force-pushed
the
pg-ocpp201-cert-handling
branch
from
822cb3f to
b912304
Compare
klemmpnx
force-pushed
the
pg-ocpp201-cert-handling
branch
2 times, most recently
from
a002ef3 to
c2c2d71
Compare
klemmpnx
force-pushed
the
pg-ocpp201-cert-handling
branch
2 times, most recently
from
7b686e0 to
d38648e
Compare
Pietfried
commented
Nov 9, 2023
lib/ocpp/v201/charge_point.cpp
Outdated
| this->send<CertificateSignedResponse>(call_result); | ||
|
|
||
| if (result != ocpp::InstallCertificateResult::Accepted) { | ||
| this->security_event_notification_req("InvalidChargingStationCertificate", std::optional<CiString<255>>{}, true, |
There was a problem hiding this comment.
Suggested change
| this->security_event_notification_req("InvalidChargingStationCertificate", std::optional<CiString<255>>{}, true, | |
| this->security_event_notification_req("InvalidChargingStationCertificate", ocpp::conversions::install_certificate_result_to_string(result), true, |
There was a problem hiding this comment.
note that tests need to be adjusted when this is applied
There was a problem hiding this comment.
done-> test update: https://github.com/PionixInternal/ocpp-testing/pull/35
lib/ocpp/v201/charge_point.cpp
Outdated
| @@ -1968,10 +2115,15 @@ void ChargePoint::handle_trigger_message(Call<TriggerMessageRequest> call) { | |||
| } | |||
| break; | |||
|
|
|||
| case MessageTriggerEnum::SignChargingStationCertificate: | |||
| EVLOG_info << "got SignChargingStationCertificate"; | |||
There was a problem hiding this comment.
Suggested change
| EVLOG_info << "got SignChargingStationCertificate"; |
…omponent vars * added handling for security: a02, a03 and a04 Signed-off-by: pietfried <[email protected]> Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
Signed-off-by: Fabian Klemm <[email protected]>
klemmpnx
force-pushed
the
pg-ocpp201-cert-handling
branch
from
d38648e to
c22842a
Compare
klemmpnx
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
rebased and adapted; pls check again / maybe run updated tests (pr: https://github.com/PionixInternal/ocpp-testing/pull/35) - but for me good to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.