cmake: add LIBOCPP_ prefix to library-own options
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
Signed-off-by: Dominik K <[email protected]>
Signed-off-by: Dominik K <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
andistorm
force-pushed
the
fix/cmake/BUILD_TESTING
branch
from
6fae93a to
ba76ca1
Compare
Signed-off-by: Andreas Heinrich <[email protected]>
Signed-off-by: Andreas Heinrich <[email protected]>
andistorm
requested review from
hikinggrass
and removed request for
hikinggrass
Signed-off-by: Andreas Heinrich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
LIBOCPP_as best-practice like done recently inboost::filesystem#177See also e.g. https://discourse.cmake.org/t/best-practices-for-option-naming/2039/3
This inconsistency was figured out in