B07 get base report simplifications #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
SNSubramanya
force-pushed
the
B07-get-base-report-simplifications
branch
from
c8bed6e to
ae8fcc8
Compare
Signed-off-by: Soumya Subramanya <[email protected]> fix formatting Signed-off-by: Soumya Subramanya <[email protected]> fix formatting Signed-off-by: Soumya Subramanya <[email protected]> fix more formatting Signed-off-by: Soumya Subramanya <[email protected]>
SNSubramanya
force-pushed
the
B07-get-base-report-simplifications
branch
from
1a2581f to
96c1237
Compare
marcemmers
requested changes
Jan 12, 2024
include/ocpp/v201/device_model.hpp
Outdated
| @@ -222,8 +209,8 @@ class DeviceModel { | |||
| /// \param component_criteria | |||
| /// \return | |||
| std::vector<ReportData> | |||
| get_custom_report_data(const std::optional<std::vector<ComponentVariable>>& component_variables = std::nullopt, | |||
| const std::optional<std::vector<ComponentCriterionEnum>>& component_criteria = std::nullopt); | |||
| get_report_data(const std::optional<std::vector<ComponentVariable>>& component_variables = std::nullopt, | |||
There was a problem hiding this comment.
I preferred the get_custom_report_data name since it really makes clear what this function is for too.
include/ocpp/v201/device_model.hpp
Outdated
| get_report_data(const std::optional<ReportBaseEnum>& report_base = std::nullopt, | ||
| const std::optional<std::vector<ComponentVariable>>& component_variables = std::nullopt, | ||
| const std::optional<std::vector<ComponentCriterionEnum>>& component_criteria = std::nullopt); | ||
| std::vector<ReportData> get_base_report_data(const std::optional<ReportBaseEnum>& report_base = std::nullopt); |
There was a problem hiding this comment.
Does this still need to be an optional? I assume it is now an always required variable here.
Signed-off-by: Soumya Subramanya <[email protected]>
Signed-off-by: Soumya Subramanya <[email protected]>
marcemmers
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some basic refactoring to remove redundant code from get base report