Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue and PR templates and CODEOWNERS file #436

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

Pietfried
Copy link
Contributor

No description provided.

@Pietfried Pietfried force-pushed the feature/issue-templates branch from 060b3aa to 974b67e Compare February 1, 2024 16:15
@Pietfried Pietfried marked this pull request as draft February 1, 2024 16:35
* Added CODEOWNERS file
* Added links to CONTRIBUTION.md and COMMUNITY.md to README.md

Signed-off-by: pietfried <[email protected]>
@Pietfried Pietfried force-pushed the feature/issue-templates branch from 974b67e to fed9d52 Compare February 2, 2024 11:33
@Pietfried
Copy link
Contributor Author

Screenshot from 2024-02-02 17-47-01
Screenshot from 2024-02-02 17-46-46

@Pietfried Pietfried changed the title Update issue templates Add issue and PR templates and CODEOWNERS file Feb 2, 2024
@Pietfried Pietfried requested a review from krealyt February 2, 2024 16:59
@lategoodbye
Copy link

Hi,
just two possible ideas for the bug report form:

  • as it's possible to compile libocpp with different compile options this should be mention under "To Reproduce"
  • i think this currently not a problem but soon it will become one - Disclaimer note that the reporter already searched for the issue before creating a new one

README.md Outdated Show resolved Hide resolved
@marcemmers
Copy link
Contributor

This is going to be really nice!

Can it automatically set tags as well? Based on the issue type and maybe also the dropdown selection?

I think the feature request can use some tweaking. It seems to be to focus mainly on the what and also on the how. I would suggest making required a "what is the problem/need" and "why is it a problem/need" since that really helps you to know what is requested. Those two could be in a single field as well.

Then an optional field that leaves room for a suggestion on the how. That leaves room for the implementer to also look at the problem and find a good solution, potentially with the suggestion.

Pietfried and others added 3 commits February 5, 2024 11:58
Co-authored-by: Philip Molares <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
* added compile options in description for bug reproduction
* Feature request: changed requirement of problem description to mandatory and solution to optional

Signed-off-by: pietfried <[email protected]>
Signed-off-by: pietfried <[email protected]>
@Pietfried Pietfried marked this pull request as ready for review February 8, 2024 07:40
.github/CODEOWNERS Outdated Show resolved Hide resolved
Signed-off-by: Piet Gömpel <[email protected]>
@Pietfried Pietfried merged commit 9ea3d29 into main Feb 14, 2024
2 of 3 checks passed
@Pietfried Pietfried deleted the feature/issue-templates branch February 14, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants