add 1.6 k01 clear all profiles with filter tests #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shankari please review -- Edit Not sure why all of the test are failing in the runner. Locally all is fine. Digging through the issue. |
couryrr-afs
force-pushed
the
couryrr/add_1.6_k01_clear_all_profiles_with_filter_tests
branch
4 times, most recently
from
f169703 to
8a1e06c
Compare
couryrr-afs
force-pushed
the
couryrr/add_1.6_k01_clear_all_profiles_with_filter_tests
branch
from
8a1e06c to
943f376
Compare
christopher-davis-afs
force-pushed
the
couryrr/add_1.6_k01_clear_all_profiles_with_filter_tests
branch
from
943f376 to
ab101c0
Compare
couryrr-afs
force-pushed
the
couryrr/add_1.6_k01_clear_all_profiles_with_filter_tests
branch
from
ab101c0 to
91738c2
Compare
Signed-off-by: Christoph <[email protected]>
Signed-off-by: Christoph <[email protected]>
Signed-off-by: Christoph <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
Signed-off-by: Coury Richards <[email protected]>
couryrr-afs
force-pushed
the
couryrr/add_1.6_k01_clear_all_profiles_with_filter_tests
branch
3 times, most recently
from
658aae8 to
9453a3b
Compare
Signed-off-by: Coury Richards <[email protected]>
|
@shankari bumping for review. |
shankari
approved these changes
Mar 11, 2024
couryrr-afs
requested review from
Pietfried,
hikinggrass,
marcemmers and
maaikez
as code owners
Pietfried
approved these changes
Mar 12, 2024
This was referenced May 2, 2024
|
Contributes to #361 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests to cover positive and negative boundaries of
SmartChargingHandler::clear_all_profiles_with_filter. The list of tests added are not exhaustive but do cover most edge cases.There are a few cases that are noted with comments that I believe are cases of concern (issues filed below):
SmartChargingHandler::clear_all_profiles_with_filterfiltering incorrectly #432SmartChargingHandler::clear_all_profiles_with_filter#446