Unit testing best practices, fix gtest linkage #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This follows the established best practices from everest.github.io Signed-off-by: Kai-Uwe Hermann <[email protected]>
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
requested review from
Pietfried,
marcemmers and
maaikez
as code owners
marcemmers
approved these changes
Feb 23, 2024
| @@ -11,11 +11,16 @@ find_package(everest-cmake 0.1 REQUIRED | |||
| ) | |||
|
|
|||
| # options | |||
| option(BUILD_TESTING "Run unit tests" OFF) | |||
| option(${PROJECT_NAME}_BUILD_TESTING "Build unit tests, used if included as dependency" OFF) | |||
There was a problem hiding this comment.
I am not so sure what the idea is behind the 2 types of BUILD_TESTING flags but LIBOCPP_BUILD_TESTING seems to work for me 👍
Pietfried
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Use conditional gtest source dependency and fix linkage of gtest
Issue ticket number and link
Checklist before requesting a review