-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/327 use case h01 reservation #854
Merged
Merged
Changes from 24 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
dfb964b
Start reservation implementation.
maaikez 92c75ac
Some changes to the reserve now callback.
maaikez 218a1d5
Add todo's
maaikez 0f97209
Merge branch 'main' into feature/327-use-case-h01-reservation
maaikez d47b009
Add todo.
maaikez c6b7242
Merge branch 'main' into feature/327-use-case-h01-reservation
maaikez d310f02
Add reservation callbacks and handlers and fix some bugs.
maaikez 706f54c
Remove unnecessary todo's. Remove unnecessary loop to check for exist…
maaikez dd6e6bb
Merge branch 'main' into feature/327-use-case-h01-reservation
maaikez f454ce7
Fix conversion of bool for connector zero support.
maaikez 0eb8847
Add reservation status.
maaikez 3823b1c
Review comments.
maaikez 27bcebb
Remove unused variable.
maaikez 045bdaf
Review comment: change parameters of reserve now callback.
maaikez 04b2c15
Merge branch 'main' into feature/327-use-case-h01-reservation
maaikez ae1d21a
Fix bug for composite schedule
maaikez d7c7792
Review comments. Some changes in functions to make it more readable.
maaikez c019173
Add new method to mock and change mock method function.
maaikez b6e8bb9
Bump version
maaikez 4a93e69
get_connector_status: When connector type is unknown, it should also …
maaikez 17fd4b4
Merge branch 'main' into feature/327-use-case-h01-reservation
maaikez 8568af1
Change comment.
maaikez 8145980
Merge branch 'main' into feature/327-use-case-h01-reservation
maaikez 6c3a3ec
Fix build after merge.
maaikez 7840131
Some changes to check if there is a reservation for an evse / id toke…
maaikez d9b3372
Review comments.
maaikez 41a8ee7
Merge branch 'main' into feature/327-use-case-h01-reservation
maaikez 0bc3c95
Fix build after merge.
maaikez c682827
Review comments
maaikez a1eb987
Formatting
maaikez 8e9a5d7
Bump version
maaikez File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we haven't used this anywhere yet in ChargePoint but the status_info could be a string_view. You can change it if you want but it's fine either way.