Refactor of message dispatching #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pietfried
requested review from
hikinggrass,
maaikez and
marcemmers
as code owners
Pietfried
force-pushed
the
feature/message-dispatcher-v2
branch
from
417b058 to
3c5606d
Compare
|
@marcemmers As discussed this only provides the message dispatching part of #849. An implementation for the DataTransfer functional block will follow in a subsequent PR. I adressed the comments you mentioned in #849 . This is now ready for review. |
5 tasks
marcemmers
reviewed
Nov 14, 2024
Pietfried
force-pushed
the
feature/message-dispatcher-v2
branch
from
3c5606d to
f9683d7
Compare
* Added new class MessageDispatcherInterface that can dispatch OCPP Call, CallResult, CallError * MessageDispatcherInterface became member of ChargePoint classes. The templated methods for sending/dispatching Call, CallResult, CallError have been moved from ChargePoint classes to MessageDispatcher Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
force-pushed
the
feature/message-dispatcher-v2
branch
from
f9683d7 to
ffc407d
Compare
marcemmers
approved these changes
Nov 14, 2024
Signed-off-by: Kai-Uwe Hermann <[email protected]>
hikinggrass
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Large refactor of message handling:
Implementation of functional blocks (starting with DataTransfer) to follow in subsequent PRs.
Issue ticket number and link
Checklist before requesting a review