Libwebsockets (usage) improvements #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcemmers
requested review from
Pietfried,
hikinggrass and
maaikez
as code owners
Pietfried
requested changes
Nov 19, 2024
…g at the same time Signed-off-by: Marc Emmers <[email protected]>
Signed-off-by: Marc Emmers <[email protected]>
Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: Marc Emmers <[email protected]>
marcemmers
force-pushed
the
me-libwebsockets-improvements
branch
from
ee58c76 to
4f153e6
Compare
Signed-off-by: Marc Emmers <[email protected]>
Pietfried
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
We encountered deadlocks in the libwebsockters layer when we were often restarting the connectivity manager.
The issue is due to 2 threads calling
join()at the same time.I've added the proper
joinable()checks and also removed the destruction and construction of libwebsockets every new config. This is no longer needed now we have one implementation that handles both secure and unsecure websockets.Issue ticket number and link
Checklist before requesting a review