Remove blocking timeout in libwebsockets connect #891
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marc Emmers <[email protected]>
…ion for OCPP1.6 ; Removed WEBSOCKET_INIT_DELAY on startup Signed-off-by: Piet Gömpel <[email protected]>
* Introduced thread_mutex protecting access to threads of libwebsockets when the ~WebsocketLibwebsockets destructor was called it attempted to acquire a lock for the connection_mutex and joins the websocket_thread . But the websocket_thread runs the client_loop that also requires the lock when calling on_conn_fail, so the client_loop which could result in a deadlock Signed-off-by: Piet Gömpel <[email protected]>
Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
requested review from
hikinggrass,
marcemmers and
maaikez
as code owners
Signed-off-by: Piet Gömpel <[email protected]>
maaikez
reviewed
Dec 4, 2024
| // If we timeouted the on_conn_fail was not dispatched, since it did not had the chance | ||
| if (timeouted && local_data->get_state() != EConnectionState::ERROR) { | ||
| EVLOG_error << "Conn failed with timeout, without disconnect dispatch, dispatching manually."; | ||
| on_conn_fail(); |
There was a problem hiding this comment.
So this is not called anymore when there is a timeout (because there is no timeout anymore). Isn't that a problem?
Why was the timeout there and can it now be just removed?
|
Closed in favor of #896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Potential replace to #889
Issue ticket number and link
Checklist before requesting a review