Code

Bugfix/libwebsocket dtor deadlock#896

Code

Merged

AssemblyJohn merged 30 commits intomainEVerest/libocpp:mainfrom bugfix/libwebsocket_dtor_deadlockEVerest/libocpp:bugfix/libwebsocket_dtor_deadlockCopy head branch name to clipboardDec 13, 2024

+897-679

Commits

Commits on Dec 12, 2024

• Added thread-safe queue for messages, removed extra mutexes

  Show description for 15b1fb2
  AssemblyJohn

  committed
  15b1fb2

• Updated websocket connect function name to better clarify what it does

  Show description for 8ff70d2
  AssemblyJohn

  committed
  8ff70d2

• Various usability and clarity fixes

  Show description for 61f5d7c
  AssemblyJohn

  committed
  61f5d7c

• Code reorder for less failure points on separate threads

  Show description for 144e991
  AssemblyJohn

  committed
  144e991

• Code reorder for less deadlock points on parallel code, moved internal reconnect attempts

  Show description for dfce5d1
  AssemblyJohn

  committed
  dfce5d1

• Update processing cases, stability improvements

  Show description for df1af70
  AssemblyJohn

  committed
  df1af70

• Fixed the dtor deadlock issue

  Show description for eb67be9
  AssemblyJohn

  committed
  eb67be9

• Updated formatting

  Show description for b3454ee
  AssemblyJohn

  committed
  b3454ee

• Clarified thread responsibility, internal mutex lock scope clarification

  Show description for b8eed4d
  AssemblyJohn

  committed
  b8eed4d

• Fixed a problem in which a reconnect is initiated during the message loop

  Show description for 7bb4a08
  AssemblyJohn

  committed
  7bb4a08

• Codacity issues and added extra checks in dtor

  Show description for 4493ff9
  AssemblyJohn

  committed
  4493ff9

• Updated header docs

  Show description for cfc5ca4
  AssemblyJohn

  committed
  cfc5ca4

• Added thread safety to external usage of ConnectionData members

  Show description for fd3d3d4
  AssemblyJohn

  committed
  fd3d3d4

• Updated behavior for CSMS initiated disconnection

  Show description for 50a7713
  AssemblyJohn

  committed
  50a7713

• Fixed a deadlock when destructing the libwebsocket handle

  Show description for 3314193
  AssemblyJohn

  committed
  3314193

• Cleanup in dtor/start

  Show description for d537814
  AssemblyJohn

  committed
  d537814

• Small cleanup/fixes

  Show description for b8cd307
  AssemblyJohn

  committed
  b8cd307

• Fixed logic error on connection initialization

  Show description for 1ca5583
  AssemblyJohn

  committed
  1ca5583

• Moved the safe queue to it's own header

  Show description for d6d5e82
  AssemblyJohn

  committed
  d6d5e82

• Comments/updates based on feedback

  Show description for d3cfa34
  AssemblyJohn

  committed
  d3cfa34

• Fixed a closed callback being called twice

  Show description for 15ca0cd
  AssemblyJohn

  committed
  15ca0cd

• Removed init_websocket() calls since they are not required anymore, we only need to change the websocket connection options

  Show description for 9f6f3a4
  

  Pietfried

  authored and

  AssemblyJohn

  committed
  9f6f3a4

• Removed unecesary timer stop

  Show description for 1448e9b
  AssemblyJohn

  committed
  1448e9b

• Removed one failure point on closed websocket

  Show description for d83c5d8
  AssemblyJohn

  committed
  d83c5d8

• Renamed websocket 'close' to 'stopped_connecting' for better ilustration of what the function does

  Show description for 453be84
  AssemblyJohn

  committed
  453be84

• Bump version

  Show description for 4aeada5
  AssemblyJohn

  committed
  4aeada5

• Implemented suggestions

  Show description for 8cedfd4
  AssemblyJohn

  committed
  8cedfd4

• Removed necesity of using 'notify_waiting_thread' from the exterior

  Show description for f678fab
  AssemblyJohn

  committed
  f678fab

• Behavior comments

  Show description for 0d7e93e
  AssemblyJohn

  committed
  0d7e93e

Commits on Dec 13, 2024

• Implented suggestions

  Show description for 6ce05ae
  AssemblyJohn

  committed
  6ce05ae