Added bounds checking for ConnectorEvseIds and ISO15118EvseId #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piet Gömpel <[email protected]>
Pietfried
requested review from
hikinggrass,
maaikez and
marcemmers
as code owners
3 tasks
hikinggrass
reviewed
Dec 10, 2024
| "readOnly": false | ||
| "readOnly": false, | ||
| "minLength": 7, | ||
| "maxLength": 1000 |
There was a problem hiding this comment.
shoudn't this also be 37 ?
There was a problem hiding this comment.
its can be a comma seperated list, so Hubject specified this maxLength with 1000
hikinggrass
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review