Censor write only variables logging and added a new callback to sanitize any logging that would be passed to the existing message_callback #911
+72
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable can be checked before the value change is logged. This prevents write-only varaiables to be logged
…o the existing message_callback. Can be used to remove secrets from log lines
WilcodenBesten
requested review from
Pietfried,
hikinggrass,
maaikez and
marcemmers
as code owners
|
The log line here: https://github.com/EVerest/libocpp/blob/main/lib/ocpp/common/websocket/websocket_libwebsockets.cpp#L996 can still leak secrets as it's not filtered. You could argue that it's debug so that's not needed, but better safe then sorry imo. Would love to here you're opinion on that. |
marcemmers
reviewed
Dec 12, 2024
| @@ -274,29 +281,37 @@ MessageLogging::~MessageLogging() { | |||
| } | |||
|
|
|||
| void MessageLogging::charge_point(const std::string& message_type, const std::string& json_str) { | |||
| std::string copy_json_str = json_str; | |||
There was a problem hiding this comment.
It would be nice if we can find a way to do this so it does not have to copy when there is no callback. These strings can be quite large (10s of KB) so we should not copy if we don't need to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review