Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Try encapsulating writes #5

Closed
wants to merge 2 commits into from
Closed

Draft: Try encapsulating writes #5

wants to merge 2 commits into from

Conversation

SirVer
Copy link
Contributor

@SirVer SirVer commented Dec 6, 2023

No description provided.

@SirVer SirVer mentioned this pull request Dec 7, 2023
Closed
dorezyuk
dorezyuk reviewed Dec 7, 2023
View reviewed changes
zvt/src/bin/status/main.rs
use std::task::{Context, Poll};
use tokio::io::{AsyncRead, AsyncWrite, ReadBuf};

pub struct LoggingTcpStream {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole idea was to support not only tcp but also other ways of communication just as the python code did. Hardcoding tcp here is a regression IMHO

@SirVer
Copy link
Contributor Author

SirVer commented Dec 8, 2023

As discussed offline closing this one. We have the plan of having source be a struct that forces users to only read and write full ZVT Packets, but this is not the time to do it.

@SirVer SirVer closed this Dec 8, 2023
@dorezyuk dorezyuk deleted the hrapp/encapsulate_packet_reading_writing branch December 12, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorezyuk dorezyuk dorezyuk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SirVer @dorezyuk