Funnel all writing through one function and add logging. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorezyuk
reviewed
Dec 7, 2023
dorezyuk
reviewed
Dec 7, 2023
| @@ -91,7 +107,7 @@ where | |||
| let bytes = read_packet_async(&mut src).await?; | |||
| let packet = Self::Output::zvt_parse(&bytes)?; | |||
| // Write the response. | |||
| src.write_all(&packets::Ack {}.zvt_serialize()).await?; | |||
| write_packet_async::<packets::Ack>(&mut src, &packets::Ack {}).await?; | |||
There was a problem hiding this comment.
i think you don't need to spell out the type here - it should be deduced from the argument
There was a problem hiding this comment.
that is what I thought, but it does not compile without it.
Signed-off-by: Holger Rapp <[email protected]>
|
Are we closing this one? |
|
Yes, superseeded by #9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.