Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align main body vertically on smaller window sizes #205 solved #216

Closed
wants to merge 4 commits into from

Conversation

sanwalsulehri
Copy link

@sanwalsulehri sanwalsulehri commented Jan 29, 2025

Changes

Using breakpoints change flex properties

Checklist

  • Issue has been linked to this PR
  • Code has been reviewed by person creating the PR
  • Automated tests have been written, if possible
  • Manual testing has been performed
  • Documentation has been updated, if necessary
  • Changes have been reviewed by second person



::-webkit-scrollbar{
display: none;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this globally deactivates scrollbars. We should not do this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok wait for a min

Copy link
Collaborator

@SoulKa SoulKa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but this breaks the UI. The response body is not visible anymore:

image

@sanwalsulehri
Copy link
Author

If you scroll it show

@sanwalsulehri
Copy link
Author

@SoulKa do you wanna to do some changes or its good on scroll

@SoulKa
Copy link
Collaborator

SoulKa commented Jan 30, 2025

The issue is, that the response body editor has no height and is therefore not visible (even if scrolling is possible):
image

Please relate to the screenshot of the target UI in #205

@sanwalsulehri
Copy link
Author

hey @SoulKa i think now fixed if you put more data then u also able to scroll

@sanwalsulehri
Copy link
Author

now @SoulKa

@sanwalsulehri sanwalsulehri requested a review from SoulKa January 30, 2025 18:14
@SoulKa
Copy link
Collaborator

SoulKa commented Jan 30, 2025

Thank you for your contribution, but this PR does not seem the reach the quality we want to have in this project. We wrote contribution guidelines which are not respected here, also we have a PR template which "test" section was removed. And the code changes itself also don't work. I will close this PR.

@SoulKa SoulKa closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants