-
Notifications
You must be signed in to change notification settings - Fork 431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨️ Add cache update feature #1550
base: develop
Are you sure you want to change the base?
✨️ Add cache update feature #1550
Conversation
@@ -7,7 +7,7 @@ | |||
/** | |||
* Base EE Model class. | |||
*/ | |||
abstract class Base { | |||
abstract class Base extends \ArrayObject { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was needed for site type PHP and wp where some existing methods were called. Those methods were called in site create too where they use array index to access properties. In site update, we use object property accessor to get the values.
@kirtangajjar Another approach can be to set the The only thing it won't do is, turn off/on To me, that will not create any issue as the value on skip cache will be Implementation
# Redis NGINX CONFIGURATION
# set $skip 0;
include /usr/local/openresty/nginx/conf/conf.d/redis.conf;
set $skip 0; # or 1 to BYPASS now you just have to change Update: We can put headers in a separate file. Then when not required we can make the file empty in order to disable the headers. cc: @mrrobot47 |
hi checking if this is still actively being developed or maintained? We also have a recent use case to enable --cache from the update command. |
Depends on:
EasyEngine/site-command#387
EasyEngine/site-type-php#87
EasyEngine/site-type-wp#194
fixes EasyEngine/feature-requests#92