-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(Modal): support disabled actions (#561)
## 📝 Changes - Passes through `isDisabled` prop to action buttons to support them being disabled - Adds some documentation to Storybook for this but felt it didn't need a full story or specific unit tests for this change Note that with Easy UI we're moving to a more constraint-based design for components to promote consistency. That's why we're not blindly allowing any button prop to pass through the actions, because it can lead to unintended Modal styles. So for now we're listing specific props that are allowed to pass through. ## ✅ Checklist - [x] Code is complete and in accordance with our style guide - [x] Stories (docs) in Storybook accompany any relevant component changes - [x] Ensure no accessibility violations are reported in Storybook - [x] Specs and documentation are up-to-date - [x] Cross-browser check is performed (Chrome, Safari, Firefox) - [x] Changeset is added
- Loading branch information
1 parent
ac19d12
commit 8fe2ca9
Showing
4 changed files
with
27 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"@easypost/easy-ui": minor | ||
--- | ||
|
||
feat(Modal): support disabled actions |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters