Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal): support custom triggers #558

Merged
merged 7 commits into from
Aug 24, 2023
Merged

feat(Modal): support custom triggers #558

merged 7 commits into from
Aug 24, 2023

Conversation

stephenjwatkins
Copy link
Member

@stephenjwatkins stephenjwatkins commented Aug 21, 2023

📝 Changes

  • Add <ModalContainer /> component to support custom triggers
  • This follows the DialogContainer pattern from React Spectrum.
  • Added a "versions" table to the Modal spec but didn't update the spec itself with the new types. Still unsure whether specs should be snapshots or living

✅ Checklist

  • Code is complete and in accordance with our style guide
  • Unit tests are written and passing
  • TSDoc is written or updated for any component API surface area
  • Stories in Storybook accompany any relevant component changes
  • Ensure no accessibility violations are reported in Storybook
  • Changeset is added
  • Specs and documentation are up-to-date
  • Cross-browser check is performed (Chrome, Safari, Firefox)

@stephenjwatkins stephenjwatkins marked this pull request as ready for review August 21, 2023 20:10

| Version | Owner | Change |
| :--------- | :-------------- | :-------------------------------------------------- |
| 2023-08-21 | stephenjwatkins | Add `<ModalContainer />` to support custom triggers |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw your comment on this. I'm not sure if it's too much info to be added as documentation in Storybook but might be cool to have them living and attached

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree. i'll think about how we could do that

@stephenjwatkins stephenjwatkins merged commit ecb5e71 into main Aug 24, 2023
@stephenjwatkins stephenjwatkins deleted the modal_menu branch August 24, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants