Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Cannot determine payment method when funding/deleting #332

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

nwithan8
Copy link
Member

@nwithan8 nwithan8 commented Apr 8, 2024

Description

  • Use payment method object type as fallback when determining type for fund, delete functions

Testing

  • Update, add unit test to confirm legacy (by ID prefix) and new (by object type) both work to determine payment method type

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team April 8, 2024 19:37
jchen293
jchen293 previously approved these changes Apr 8, 2024
Justintime50

This comment was marked as duplicate.

@nwithan8 nwithan8 merged commit 8b20f82 into master Apr 10, 2024
8 checks passed
@nwithan8 nwithan8 deleted the payment_methods branch April 10, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants