Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP - No Review] Upgrade download-artifact action to v4 #11751

Closed
wants to merge 1 commit into from

Conversation

Thenlie
Copy link
Contributor

@Thenlie Thenlie commented Nov 8, 2024

What does this PR do?

Improve repo

Description

actions/download-artifact v3 is being deprecated by the end of this year. We need to upgrade to v4 to avoid future issues. Unfortunately, due to actions/download-artifact#339 this might not be a straight forward as updating. This PR will test that concern.

#11749

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@github-actions github-actions bot added the linter error Please, correct build errors found by linter! label Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

1 similar comment
Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@eshellman
Copy link
Collaborator

that's very strange

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@eshellman
Copy link
Collaborator

Oh, I get it, you're testing a bad linter case. carry on...

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

Copy link

github-actions bot commented Nov 8, 2024

Linter failed, fix the error(s):

free-programming-books/casts/free-podcasts-screencasts-de.md
9:1-9:79  warning  Incorrect number of blank lines between last section and next heading  blank-lines-1-0-2  remark-lint

@github-actions github-actions bot removed the linter error Please, correct build errors found by linter! label Nov 8, 2024
@Thenlie Thenlie closed this Nov 8, 2024
@Thenlie
Copy link
Contributor Author

Thenlie commented Nov 8, 2024

Closed this just to avoid all the lint error noise on the final PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants