Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix actions/download-artifact v4 #11754

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

Thenlie
Copy link
Contributor

@Thenlie Thenlie commented Nov 8, 2024

What does this PR do?

Improve repo

Description

Bug 1

This issue originally came up when a PR was failing the check-url action at the download artifact step. At the time, downgrading download-artifact to v3 resolved the issue. Since that version is now being deprecated, a new solution is needed.

After some investigation, I have found that the download only fails when a file is named README.md specifically. While I don't understand the root cause behind this issue (I am 99% sure it is in the upstream repo), we can get around it by simply renaming README.md before uploading it. This does not change the file name in the repo, just the artifact.

Bug 2

As I was working on this, I found another issue that was due to a problem with our action. If someone update two files with the same name (ex. README.md and docs/README.md) the upload step fails because the file names are identical. Previously we would strip the path from the file name so both of the example files would be uploaded as README.md. I have updated the upload step to use the entire path of the file to avoid this problem. Now the example files would be uploaded as README.md and docs-README.md respectively.

Checklist:

  • Read our contributing guidelines.
  • Search for duplicates.
  • Include author(s) and platform where appropriate.
  • Put lists in alphabetical order, correct spacing.
  • Add needed indications (PDF, access notes, under construction).
  • Used an informative name for this pull request.

Follow-up

  • Check the status of GitHub Actions and resolve any reported warnings!

Closes #11749

@eshellman eshellman merged commit 0d6a64e into EbookFoundation:main Nov 8, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

artifacts v3 deprecation
2 participants