Adjust keyboard detection on Android #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… .822 with keyboard down)
|
Thanks for the contribution, this functionality is error-prone and needs Android native tests against different devices with different sizes since this is very dynamic. However, we don't plan to work on this temp fork much longer, the plugin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ratio used in android keyboard check was 85%. i.e. if less than 85% of the screen is available, assume the keyboard is up.
On the Pixel 9 Pro, only 82.2% of the screen is available in landscape mode with normal status bar and gesture bar on the bottom. This PR adjusts the check ratio from 85% to 82% so landscape on Pixel 9 Pro isn't incorrectly flagged as keyboard visible.