Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug #516 - Use latest Tycho and Java 17 for building #543

Closed
wants to merge 1 commit into from
Closed

Bug #516 - Use latest Tycho and Java 17 for building #543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/maven.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [ '11', '17' ]
java: [ '17' ]
name: Java ${{ matrix.java }} compile
steps:
- uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .mvn/extensions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
<extension>
<groupId>org.eclipse.tycho.extras</groupId>
<artifactId>tycho-pomless</artifactId>
<version>2.5.0</version>
<version>3.0.4</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>3.0.4</version>
<version>4.0.4</version>

The latest Tycho version as of today is 4.0.4

</extension>
</extensions>
2 changes: 1 addition & 1 deletion releng/org.eclipse.nebula.nebula-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Contributors:

<properties>

<tycho-version>2.6.0</tycho-version>
<tycho-version>3.0.4</tycho-version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to use a maven.config file and then share the Tycho version for extension/pom in that file like described here: https://tycho.eclipseprojects.io/doc/latest/StructuredBuild.html#pomless-builds

<tycho-extras-version>${tycho-version}</tycho-extras-version>
<mockito-version>2.8.9</mockito-version>
<findbugs-version>2.3.2</findbugs-version>
Expand Down
Loading