Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a changelog file #185

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Add a changelog file #185

merged 5 commits into from
Jun 22, 2023

Conversation

SarahAlidoost
Copy link
Member

@SarahAlidoost SarahAlidoost commented Jun 20, 2023

Description

closes #146

This pr can include notes of the latest release 1.3.0 when the draft release is published. The draft release is waiting for pystemmusscope 0.2.2 release.

Update executable file

Please re-generate exe file if matlab codes are changed. About how to create an exe file, see exe readme.

Checklist

  • Add a reference to related issues.
  • @mentions of the person or team responsible for reviewing proposed changes.
  • This pull request has a descriptive title.
  • Code is written according to the guidelines.
  • The checks by MISS_HIT style checker and linter, below the pull request, are successful (green).
  • Documentation is available.
  • Model runs successfully.

@BSchilperoort
Copy link
Contributor

BSchilperoort commented Jun 21, 2023

Nice! I was looking for the changelog again earlier haha. We should add instructions to update the changelog to the PR template.

Let's add the unreleased changes as well (I think I got them all in the suggestion).

Co-authored-by: Bart Schilperoort <[email protected]>
@BSchilperoort BSchilperoort marked this pull request as ready for review June 22, 2023 09:33
@BSchilperoort BSchilperoort self-requested a review June 22, 2023 09:33
Copy link
Contributor

@BSchilperoort BSchilperoort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to finally have a changelog file 😄

@SarahAlidoost SarahAlidoost merged commit 51668dc into main Jun 22, 2023
@SarahAlidoost SarahAlidoost deleted the add_changelog branch June 22, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding a changelog file
2 participants