Avoid locale issues in generating forcing .mat files #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
PyStemmusScope/utils.py
Outdated
| @@ -67,3 +67,23 @@ def to_absolute_path( | |||
| must_exist = os_name() == 'nt' | |||
|
|
|||
| return pathlike.expanduser().resolve(strict=must_exist) | |||
|
|
|||
|
|
|||
| def sanitize_mat_file(filename): | |||
There was a problem hiding this comment.
Let's use another function name that shows what the function is doing, perhaps something like remove_dates_from_header
SarahAlidoost
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
@BSchilperoort thanks, just a minor comment about the name of the function. I tested the PR on linux (my own laptop using exe and crib using ocatve), and with MATLAB on Snellius. 👍
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tackles issue #38. The problem is circumvented by removing the date string entirely and making it blank.
Note: PR includes commits of #45, to avoid merge conflicts and to have the Windows tests work.
Discussion of this "bug" on hdf5storage.
Tested on: