Remove black, switch to ruff for formatting #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There still seems to be an issue for the 3.11 Windows run. Last time restarting it worked. |
|
SarahAlidoost
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
@BSchilperoort thanks for the fixes 👍 nice that you added the fixture slow from pytest . I liked it 😄
Yes the pytest test marks are really nice! Thanks for the review 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved to ruff. The way ruff handles the
# fmt: offcommands is a bit different so some small refactoring was required.Additionally I added a way to skip running the slow tests to speed up development.
Some tests are quite memory intensive: perhaps the windows CI occasionally fails due to running out of memory.