This repository has been archived by the owner on Aug 7, 2024. It is now read-only.
Reduce bg-size on :after to fix Safari bug #9770
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Safari a background is shown when adding the
glow
animation effect to the Social Media Buttons (Links Section on Profile). This is due Safari and Safari on iOS currently not supporting animation and transition on CSS pseudo-elements like:after
, while other browsers do.Resources: https://developer.mozilla.org/en-US/docs/Web/CSS/::after
Fixes Issue
Closes #9461
Changes proposed
By setting the
background-size
to100%
to the:after
animation, the bug disappears. Setting the value more or less than100%
retains the bug, setting it to0
would remove the glow as a whole, which is neither wanted nor needed.💡 Due to this settings, notice that the heavy glow effect is now gone in general in all browsers.
Check List (Check all the applicable boxes)
Screenshots
Please see screenshots of the changes in Safari Browser.
Before the changes
After the changes
Note to reviewers
I added a
/* comment */
to theline 43
of my changes in case browser support changes in the future and the original effect will not be forgotten. This can be deleted if wished.