Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaner madness #566

Merged
merged 10 commits into from
Oct 2, 2023
Merged

Cleaner madness #566

merged 10 commits into from
Oct 2, 2023

Conversation

swansontec
Copy link
Contributor

@swansontec swansontec commented Sep 27, 2023 •
edited
Loading

Dependencies

none

Description

none

@swansontec
Deprecate listRecoveryQuestionChoices
d6af0da
@swansontec
Clean login dumps more correctly
e7cec9c 
Since the `EdgeLoginDump` is typed, we shouldn't clean it. We still need to clean the server payload and the repo dumps.
@swansontec swansontec force-pushed the william/cleaner-madness branch from 116182f to 9038285 Compare September 28, 2023 20:46
peachbits
peachbits approved these changes Oct 2, 2023
View reviewed changes
src/core/fake/fake-server.ts Outdated
return await payloadResponse(
wasLoginPayload(await makeLoginPayload(db, login))
)
return payloadResponse(wasLoginPayload(await makeLoginPayload(db, login)))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this await too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, fixed.

@swansontec
Copy link
Contributor Author

/rebase

@swansontec swansontec force-pushed the william/cleaner-madness branch from ce28083 to 6ee2696 Compare October 2, 2023 22:47
@swansontec swansontec force-pushed the william/cleaner-madness branch from 6ee2696 to b9b3f07 Compare October 2, 2023 22:50
@swansontec swansontec enabled auto-merge October 2, 2023 22:50
@swansontec swansontec merged commit dd661dc into master Oct 2, 2023
3 checks passed
@swansontec swansontec deleted the william/cleaner-madness branch October 2, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peachbits peachbits peachbits approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swansontec @peachbits