Fetch swap quotes #570
Merged
Fetch swap quotes #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
requested changes
Oct 17, 2023
| @@ -94,7 +96,6 @@ export async function fetchSwapQuote( | |||
| ) | |||
| ) | |||
| } | |||
| if (promises.length < 1) throw new Error('No swap providers enabled') | |||
|
|
|||
There was a problem hiding this comment.
Why was this error removed?
There was a problem hiding this comment.
It's moved to the outer fetchSwapQuote function. Now that fetchSwapQuotes returns an array, we return an empty array if there are no enabled plugins.
We weren't closing quotes correctly, so the objects would linger in the bridge. Also use `??` to avoid TypeScript errors.
swansontec
force-pushed
the
william/fetch-swap-quotes
branch
from
8e0422c to
3e4c3ea
Compare
Jon-edge
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none