Fetch plugin data from info server #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
commented
Mar 11, 2024
samholmes
requested changes
Mar 12, 2024
samholmes
approved these changes
Mar 22, 2024
src/core/currency/currency-pixie.ts
Outdated
| for (const pluginId of Object.keys(plugins.currency)) { | ||
| const plugin = plugins.currency[pluginId] | ||
| const newPayload = infoCache.corePlugins?.[pluginId] ?? {} | ||
| const oldPayload = lastInfo?.corePlugins?.[pluginId] ?? {} |
There was a problem hiding this comment.
Unnecessary ?. for lastInfo?.
src/util/match-json.ts
Outdated
There was a problem hiding this comment.
Oof! I didn't know match-json.ts was missing from the first review. Good catch
swansontec
force-pushed
the
william/info-fetch
branch
from
042ccce
to
0f85881
Compare
swansontec
force-pushed
the
william/info-fetch
branch
from
0f85881
to
c2301f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none