Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for engines' otherMethodsWithKeys #610

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

Jon-edge
Copy link
Contributor

@Jon-edge Jon-edge commented Aug 9, 2024

Same as otherMethods, but also passes private keys to the engine method.

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

@swansontec swansontec force-pushed the jon/other-methods-private-key branch from a77f0a8 to 8075d49 Compare August 9, 2024 16:49
@Jon-edge Jon-edge requested a review from swansontec August 12, 2024 18:16
@Jon-edge Jon-edge changed the title Add support for engines' otherMethodsPrivateKey Add support for engines' otherMethodsWithKeys Aug 12, 2024
src/types/types.ts Outdated Show resolved Hide resolved
These methods will be added to `EdgeCurrencyEngine.otherMethods`, but will receive private keys on the way down to the engine.
@Jon-edge Jon-edge force-pushed the jon/other-methods-private-key branch from 6fcbb2d to f5289c5 Compare August 12, 2024 18:30
@Jon-edge Jon-edge enabled auto-merge August 12, 2024 18:30
@Jon-edge Jon-edge merged commit 3b454bf into master Aug 12, 2024
2 checks passed
@Jon-edge Jon-edge deleted the jon/other-methods-private-key branch August 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants