Fetch challenge #614
Merged
Fetch challenge #614
+48
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
swansontec
force-pushed
the
william/fetch-captcha
branch
from
412a96d to
e41eb1f
Compare
Jon-edge
approved these changes
Sep 4, 2024
| /** Preemptively requests a CAPTCHA for account creation. */ | ||
| readonly fetchChallenge: () => Promise<{ | ||
| challengeId: string | ||
| /** If this is missing, the challenge is already solved. */ |
There was a problem hiding this comment.
Optional: An explicit status would make this more clear without having to read prop documentation. Or a more descriptive var name like unsolvedChallengeUri
There was a problem hiding this comment.
I had it that way originally, but changed it this way for type-safety. You literally can't show the challenge to a user if there is no URL - what would go in the modal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none