Creation dates #617
Merged
Creation dates #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/creation-dates
branch
from
87ab73a to
d3cf828
Compare
peachbits
approved these changes
Sep 9, 2024
src/types/server-types.ts
Outdated
| @@ -13,6 +13,13 @@ export interface EdgeBox { | |||
| iv_hex: Uint8Array | |||
| } | |||
|
|
|||
| /** | |||
| * Encrypted wallet private keys include an optional creation date. | |||
There was a problem hiding this comment.
This comment says created is optional but it's required in it's definition below and in the cleaner asEdgeKeyBox cleaner
There was a problem hiding this comment.
Good catch. Fixed.
swansontec
force-pushed
the
william/creation-dates
branch
from
d3cf828 to
227b2b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none