Allow known transaction types past spam filter

[peachbits]

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

• Yes
• No

Dependencies

none

Description

none

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1207973610789798

[swansontec]

I had a sidebar with Sam about this, and we agree that this new logic is more correct. With this change, we will report transactions to the GUI if the engine reports them to us. We no longer care about 0 amounts or any other funny business - if the engine doesn't want a transaction to appear, it shouldn't report it to the core. For token transactions, this includes providing a non-null parentNetworkFee, which will cause the transaction to appear on the parent chain in all cases.

This will probably create a follow-on bug where 0x gasless swaps produce 0-amount, 0-fee transactions on the parent chain. It's up to the engine to fix this, not the core.

[swansontec]

This condition is gnarly. Can we do:

const isKnown  =
  tx.isSend ||
  edgeTx.assetAction != null ||
  edgeTx.chainAction != null || 
  edgeTx.chainAssetAction != null ||
  edgeTx.savedAction != null
if (!isKnown && lt(abs(nativeAmount), spamThreshold)) continue