Update display-key methods #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/display-keys
branch
from
6b237c5
to
b8e0dcb
Compare
peachbits
approved these changes
Jul 31, 2023
swansontec
force-pushed
the
william/display-keys
branch
from
b8e0dcb
to
d7edaaa
Compare
The latest core will use these methods if available.
swansontec
force-pushed
the
william/display-keys
branch
from
d7edaaa
to
c00fa4f
Compare
swansontec
force-pushed
the
william/display-keys
branch
from
c00fa4f
to
8168d3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Dependencies
noneDescription
Maybe use the "files changed" view, since that will make the review easier. We could even go so far as to squash the two commits together.
However, the second commit is a breaking change, since it means we will no longer be compatible with older core versions.