Paul/xrp dex #598
Paul/xrp dex #598
Conversation
paullinator
force-pushed
the
paul/xrpDex
branch
from
e0f8cc7 to
8432f50
Compare
src/ripple/rippleTypes.ts
Outdated
| export interface RippleNetworkLocation { | ||
| currency: string | ||
| issuer: string | ||
| } |
There was a problem hiding this comment.
You already have asXrpNetworkLocation a few lines above. You can do type RippleNetworkLocation = ReturnType<typeof asXrpNetworkLocation>
There was a problem hiding this comment.
Ah good catch. how'd i miss that.
src/ripple/RippleEngine.ts
Outdated
| return nativeAmount | ||
| } else { | ||
| const { networkLocation, denominations } = this.allTokensMap[tokenId] | ||
| const { currency, issuer } = networkLocation as RippleNetworkLocation |
There was a problem hiding this comment.
Please use asXrpNetworkLocation instead of a type-cast.
src/ripple/RippleEngine.ts
Outdated
| const TakerGets = this.nativeToXrpAmount( | ||
| fromNativeAmount, | ||
| fromTokenId | ||
| ) | ||
| const TakerPays = this.nativeToXrpAmount(toNativeAmount, toTokenId) | ||
|
|
||
| const Expiration = unixTimeToRippleTime( | ||
| (expiration ?? DEX_ORDER_EXPIRATION_TIME_DEFAULT_S) * 1000 | ||
| ) |
There was a problem hiding this comment.
Optional: I see that you are using uppercase, because that is what the OfferCreate JSON expects. However, we generally reserve uppercase names for types. Would it make more sense to use lowercase for the variables, and then do { ... Expiration: exipration, ... } and such to change case inside the object?
There was a problem hiding this comment.
it crossed my mind but went for the convenient route. will do
|
/rebase |
github-actions
bot
force-pushed
the
paul/xrpDex
branch
from
961e1a6 to
a635901
Compare
Matches edge-exchange-plugins
Makes this generic for other types of txs
paullinator
force-pushed
the
paul/xrpDex
branch
from
a635901 to
188efca
Compare
CHANGELOG
Add Ripple makeTx routine for xrp dex OfferCreate
Dependencies
noneDescription
none