Multiple memos #605
Merged
Multiple memos #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swansontec
force-pushed
the
william/multiple-memos
branch
from
5144b13
to
4d3e095
Compare
peachbits
requested changes
Aug 24, 2023
src/common/validateMemos.ts
Outdated
| if (option.type === 'number') { | ||
| const value = asMaybe(asIntegerString)(memo.value) | ||
| if (value == null) { | ||
| return `is not valid hexadecimal` |
There was a problem hiding this comment.
Should be 'is not valid number'
swansontec
force-pushed
the
william/multiple-memos
branch
from
4d3e095
to
c5c0379
Compare
peachbits
approved these changes
Aug 25, 2023
swansontec
force-pushed
the
william/multiple-memos
branch
3 times, most recently
from
c3b7053
to
bce841d
Compare
The core is responsible for doing this, not the plugins.
We want to put the deprecated things in one place.
swansontec
force-pushed
the
william/multiple-memos
branch
from
d09e92d
to
4b62584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
- added: Support the new memo metadata fields in
- added: Accept memos in the new
- added: Detect and report on-chain memos for Algorand.
- fixed: Update legacy memo metadata to match reality.
noneEdgeCurrencyMemo.EdgeSpendInfoformat.Dependencies
EdgeApp/edge-core-js#559
Future:
#603
Description
none