Add Liberland #606
Merged
Add Liberland #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
peachbits
commented
Aug 25, 2023
•
peachbits
commented
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205147741891806
swansontec
approved these changes
Aug 25, 2023
src/polkadot/PolkadotEngine.ts
Outdated
| const transfer = await this.api.tx.balances.transferKeepAlive( | ||
| publicAddress, | ||
| nativeAmount | ||
| const edgeMetaToken = this.allTokens.find( |
There was a problem hiding this comment.
Call this one edgeToken
src/polkadot/PolkadotEngine.ts
Outdated
| /* | ||
| HACK: We cannot query transactions if a currency doesn't have a subscanBaseUrl | ||
| */ | ||
| if (this.networkInfo.subscanBaseUrl === '') { |
There was a problem hiding this comment.
Optional: Could we make subscanBaseUrl: string | undefined? I really don't like blank-string checks, if we can use undefined instead.
src/polkadot/info/liberlandInfo.ts
Outdated
Comment on lines
27
to
46
| // Basic currency information: | ||
| currencyCode: 'LLD', | ||
| displayName: 'Liberland', | ||
| pluginId: 'liberland', | ||
| walletType: 'wallet:liberland', | ||
|
|
||
| defaultSettings: {}, | ||
|
|
||
| addressExplorer: '', | ||
| transactionExplorer: | ||
| 'https://polkadot.js.org/apps/?rpc=wss%%3A%%2F%%2Fmainnet.liberland.org%%2F#/explorer/query/%s', | ||
|
|
||
| denominations: [ | ||
| // An array of Objects of the possible denominations for this currency | ||
| { | ||
| name: 'LLD', | ||
| multiplier: '1000000000000', | ||
| symbol: '' | ||
| } | ||
| ], | ||
| metaTokens: makeMetaTokens(builtinTokens) // Deprecated |
There was a problem hiding this comment.
Delete the // Basic currency information: and // An array of Objects of the possible denominations for this currency comments, and move defaultSettings to the deprecated section:
// Deprecated:
defaultSettings: {},
metaTokens: makeMetaTokens(builtinTokens)
Comment on lines
27
to
46
| // Basic currency information: | ||
| currencyCode: 'LDN', | ||
| displayName: 'Liberland Testnet', | ||
| pluginId: 'liberlandtestnet', | ||
| walletType: 'wallet:liberlandtestnet', | ||
|
|
||
| defaultSettings: {}, | ||
|
|
||
| addressExplorer: '', | ||
| transactionExplorer: | ||
| 'https://polkadot.js.org/apps/?rpc=wss%%3A%%2F%%2Ftestchain.liberland.org%%2F#/explorer/query/%s', | ||
|
|
||
| denominations: [ | ||
| // An array of Objects of the possible denominations for this currency | ||
| { | ||
| name: 'LDN', | ||
| multiplier: '1000000000000', | ||
| symbol: '' | ||
| } | ||
| ], | ||
| metaTokens: makeMetaTokens(builtinTokens) // Deprecated |
There was a problem hiding this comment.
Same thing here: Delete the // Basic currency information: and // An array of Objects of the possible denominations for this currency comments, and move defaultSettings to the deprecated section:
// Deprecated:
defaultSettings: {},
metaTokens: makeMetaTokens(builtinTokens)
peachbits
force-pushed
the
liverlandTemp
branch
from
6d0f36a
to
2c989bf
Compare
swansontec
approved these changes
Aug 29, 2023
This supports tokens on the assets pallet
swansontec
force-pushed
the
liverlandTemp
branch
from
2c989bf
to
c63a5c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.