Fix filecoin spend saving #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Sep 8, 2023
|
|
||
| const edgeTransaction: EdgeTransaction = { | ||
| txid: '', | ||
| date: 0, | ||
| currencyCode, | ||
| blockHeight: 0, | ||
| nativeAmount: `-${totalTxAmount}`, | ||
| isSend: nativeAmount.startsWith('-'), |
There was a problem hiding this comment.
Why do other engines detect sends based on the sign of the number?
src/zcash/ZcashEngine.ts
Outdated
| nativeAmount: `-${totalTxAmount}`, // nativeAmount | ||
| isSend: nativeAmount.startsWith('-'), | ||
| nativeAmount: txNativeAmount, // nativeAmount | ||
| isSend: txNativeAmount.startsWith('-'), |
samholmes
force-pushed
the
sam/filecoin-saved-sends
branch
from
57af2d3 to
4a02b12
Compare
paullinator
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The date field was missing from the signed transactions so it wasn't being saved (I suppose that's a requirement by the CurrencyEngine implementation). Also,
isSendhad a bug that was copied fromZcashEngine; now it's fixed in both places.CHANGELOG
saveTx)Dependencies
noneDescription
none