Filecoin network query fixes #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
requested changes
Sep 8, 2023
src/filecoin/FilecoinEngine.ts
Outdated
| @@ -331,6 +331,8 @@ export class FilecoinEngine extends CurrencyEngine< | |||
| }): void => { | |||
| this.addTransaction(this.currencyInfo.currencyCode, tx) | |||
| this.onUpdateTransactions() | |||
| this.otherData.knownTxids[tx.txid] = true | |||
There was a problem hiding this comment.
There is already an engine.txIdMap you should use. It's automatically kept up to date by addTransaction
There was a problem hiding this comment.
Is it available after loading the engine? If so, I'll use that instead of the otherData which does get loaded.
src/filecoin/FilecoinEngine.ts
Outdated
| } | ||
| // Exit early because we reached transaction history from previous | ||
| // check | ||
| if (this.otherData.knownTxids[txid]) return |
There was a problem hiding this comment.
Use
if (this.findTransaction('FIL', normalizeAddress(txid)) !== -1) return
There was a problem hiding this comment.
I cannot use this because it's not available after loading the engine.
samholmes
force-pushed
the
sam/fil-network-query
branch
from
0b6e0e5
to
16a37e1
Compare
The transaction list data doesn't load until `getTransactions` is called or a new transaction is saved. This means it's not suitable for checking the known txid from prior syncs.
Filfox has a convenient API for retrieving fee info on a message. Filscan doesn't have an known API for getting the fee amounts without figuring out how to calculate the fee amounts from four or five fee related fields on a Filecoin message.
samholmes
force-pushed
the
sam/fil-network-query
branch
from
16a37e1
to
4d95709
Compare
paullinator
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heads up. This disables Filscan because I haven't found a convenient way to calculate fees from Filscan's API. I haven't quit wrapped my head around how Filecoin fees are calculated, so rather than calculating the fee from the message fields, I use a hack to peer into the "transfer" data returned by Filfox.
CHANGELOG
Dependencies
noneDescription
none