Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updateInfoPayload implementation #795

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Add updateInfoPayload implementation #795

merged 6 commits into from
Jul 9, 2024

Conversation

samholmes
Copy link
Collaborator

@samholmes samholmes commented Jul 4, 2024

This will update the networkInfo with the infoPayload data. A couple
questions remain:

  1. Should the infoPayload update more than the networkInfo for a plugin?
  2. Is it important for the network adapters to be immediately recreated
    when the config changes, or is it okay for this to occur on engine
    restart?

CHANGELOG

Does this branch warrant an entry to the CHANGELOG?

  • Yes
  • No

Dependencies

none

Description

none

Copy link
Contributor

@swansontec swansontec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding type safety to the info server.

Also, the "Add updateInfoPayload implementation to" commit message is missing a

src/ethereum/EthereumTools.ts Show resolved Hide resolved
src/algorand/AlgorandTools.ts Outdated Show resolved Hide resolved
@samholmes samholmes enabled auto-merge July 9, 2024 17:04
@samholmes samholmes merged commit 17b07c4 into master Jul 9, 2024
2 checks passed
@samholmes samholmes deleted the sam/info-payload branch July 9, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants