Support signing non-hex messages #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peachbits
requested changes
Jul 23, 2024
src/ethereum/EthereumEngine.ts
Outdated
| const messageBuffer = hexToBuf(message) | ||
| const messageBuffer = isHex(message) | ||
| ? hexToBuf(message) | ||
| : Buffer.from(message) |
There was a problem hiding this comment.
I'm not sure it's a good idea to use Buffer.from without specifying the encoding. Instead maybe explicitly test for different types of strings and use base16 and base64 to create the uint8array and to support arbitrary text by using Buffer.from(arg, 'ascii')
Jon-edge
force-pushed
the
jon/non-hex-eth-signing
branch
4 times, most recently
from
31989db
to
c0afe35
Compare
Jon-edge
commented
Jul 29, 2024
peachbits
requested changes
Jul 29, 2024
src/ethereum/EthereumEngine.ts
Outdated
| @@ -143,8 +144,19 @@ export class EthereumEngine extends CurrencyEngine< | |||
| ] | |||
|
|
|||
| this.utils = { | |||
| signBytes: (bytes: Uint8Array, privateKeys: EthereumPrivateKeys) => { | |||
There was a problem hiding this comment.
Remove signBytes and signMessage from utils
peachbits
approved these changes
Jul 29, 2024
Jon-edge
force-pushed
the
jon/non-hex-eth-signing
branch
3 times, most recently
from
9b0122d
to
36edf19
Compare
Required for signing Bity orders
Jon-edge
force-pushed
the
jon/non-hex-eth-signing
branch
from
36edf19
to
2bba3e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for signing Bity orders
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
EdgeApp/edge-core-js#605
Description
none