(Thorchain) Replace rpc tx_search with midgard transaction query #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Aug 30, 2024
Comment on lines
+809
to
+820
| let gasPrice = average | ||
| switch (opts.networkFeeOption) { | ||
| case 'low': { | ||
| gasPrice = low | ||
| break | ||
| } | ||
| case 'high': { | ||
| gasPrice = high | ||
| break | ||
| } | ||
| case 'custom': { | ||
| throw new Error('Custom fee not supported') |
There was a problem hiding this comment.
You can't ignore this comment
If only this was valid JS code:
const gasPrice = match opts.networkFeeOption === {
'low': low,
'high': high,
'custom': throw new Error('Custom fee not supported')
}It's called pattern matching, but the syntax idea that I just thought of seems nice and elegant. But this is in TC39's hands.
const gasPrice = match(opts.networkFeeOption)(
(case = Type('low')) => low,
(case = Type('high')) => high,
(case = Type('custom')) => { throw new Error(...) }
)^ This API is doable though ^
whatever
Thorchain has enough unique functionality to warrant its own engine. So far, this engine can handle a planned hard fork. Future commits will move transaction query, balance query, transaction fees, and future PRs can move other methods and registry entries
Will be called from multiple transaction query functions
peachbits
force-pushed
the
matthew/thorchain-engine
branch
from
4c9ef5c
to
cd8b2b4
Compare
samholmes
approved these changes
Sep 3, 2024
peachbits
force-pushed
the
matthew/thorchain-engine
branch
from
cd8b2b4
to
4f6d147
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none