Handle FIO 404 errors for getFioAddresses #828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
force-pushed
the
sam/fix-fio-get-address
branch
from
6d6a762
to
c5ac5c4
Compare
Jon-edge
requested changes
Sep 4, 2024
There was a problem hiding this comment.
I'm not so sure about hiding all errors here. We're assuming the caller would never be interested in knowing why something went wrong. There's no way to differentiate between no addresses/domains vs an error. I could imagine a future manual refresh UI wanting to know if these calls failed for some reason
There was a problem hiding this comment.
Hmm.. No that I think about; I'm not sure about calling refreshFioAddresses on ever call to getFioAddresses. Why are we doing what was a background task on ever call to getFioAddresses? What was the motivation for your change again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none