XRPDEX - don't convert currency field #372
Open
+27
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two correct 'currency' formats for XRP https://xrpl.org/docs/references/protocol/data-types/currency-formats#currency-codes We should use the one found in the networkLocation instead of converting or looking for it in the tokenId.
paullinator
requested changes
Feb 26, 2025
src/swap/defi/xrpDex.ts
Outdated
| const toCurrency = | ||
| toTokenId != null ? toTokenId.split('-')[0] : toCurrencyCode | ||
| let fromIssuer: string | undefined | ||
| let fromCurrency: string = fromCurrencyCode |
There was a problem hiding this comment.
fromCurrencyCode is getting deprecated, we shouldn't be using it
There was a problem hiding this comment.
if tokenId == null then set the fromCurrency to the main asset of the wallet
wallet.currencyInfo.currencyCode
src/swap/defi/xrpDex.ts
Outdated
| } | ||
|
|
||
| let toIssuer: string | undefined | ||
| let toCurrency: string = toCurrencyCode |
paullinator
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
none