UI4: LoginUI Fixes #150
Merged
UI4: LoginUI Fixes #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/ui4/misc-login-changes
branch
2 times, most recently
from
157a78e to
dd143e0
Compare
Jon-edge
changed the title
|
Jon-edge
force-pushed
the
jon/ui4/misc-login-changes
branch
from
dd143e0 to
c0043d0
Compare
Jon-edge
force-pushed
the
jon/ui4/misc-login-changes
branch
13 times, most recently
from
3f10536 to
af5b052
Compare
Jon-edge
changed the title
|
Was unable to get Just copied over the relevant styles for now |
swansontec
requested changes
Jan 22, 2024
package.json
Outdated
| @@ -48,6 +48,7 @@ | |||
| "date-fns": "^2.23.0", | |||
| "qrcode-generator": "^1.4.4", | |||
| "react-native-airship": "^0.2.9", | |||
| "react-native-haptic-feedback": "1.14.0", | |||
There was a problem hiding this comment.
Any time you add a native dependency, you need to add an entry to the readme file, listing the dependency name & acceptable version range.
If you make the dependency mandatory, you also need to do a breaking release.
Jon-edge
force-pushed
the
jon/ui4/misc-login-changes
branch
5 times, most recently
from
947a4bc to
b667fce
Compare
swansontec
approved these changes
Jan 22, 2024
Comment on lines
+4
to
+7
| try { | ||
| const ReactNativeHapticFeedback = require('react-native-haptic-feedback') | ||
| ReactNativeHapticFeedback.trigger(type) | ||
| } catch (_) {} |
There was a problem hiding this comment.
Thanks, but we still need to add this to the readme file.
| @@ -190,10 +191,14 @@ export const PasswordLoginScene = (props: Props) => { | |||
| }) | |||
|
|
|||
| const handleSubmitPassword = useHandler(() => { | |||
| console.debug('handleSubmitPassword') | |||
Jon-edge
force-pushed
the
jon/ui4/misc-login-changes
branch
from
b667fce to
547522b
Compare
Jon-edge
force-pushed
the
jon/ui4/misc-login-changes
branch
from
547522b to
7ced545
Compare
In the interest of time and incomplete upgrade specs, Not using AlertCardUi4 for the password requirements, because there is dynamic styling. Could use an overall redesign.
To be synchronized with gui later
- Change "Get Started" -> "Create Account" - Use ButtonsViewUi4
Opting not to use ButtonsViewUi4 for now since there's a lot of dead space on the scene, and to avoid updating the other account creation scenes. We can fully remove floating buttons later hopefully with some additional redesigns on these scenes.
Keeping the increased margins for the text inputs
Can probably refactor the logic better, but trying not to mess with it too much to avoid regression.
Jon-edge
force-pushed
the
jon/ui4/misc-login-changes
branch
from
7ced545 to
7b88655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneDescription
Update legacy components to UI4
Restyle scenes/components
Password error message fix